WIP: Attempt to fix failng Rubocop lint checks #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
force-pushed
the
fix-rubocop
branch
2 times, most recently
from
8b15c4f
to
707aafb
Compare
juniorsysadmin
force-pushed
the
fix-rubocop
branch
from
707aafb
to
0b60129
Compare
| if /#{resource[:name]}@([\d\.]+)/ =~ npm('outdated', '--global', resource[:name]) | ||
| @latest = $1 | ||
| if /#{resource[:name]}@([\d\.]+)/ =~ npm('outdated', '--global', resource[:name]) | ||
| @latest = Regexp.last_match(1) | ||
| else | ||
| @property_hash[:ensure] unless @property_hash[:ensure].is_a? Symbol | ||
| end |
There was a problem hiding this comment.
this whole function feels very unruby… not sure ow to make it better
or simplify it for that matter
perhaps split is all we need
so, basically,
def latest
outdated = npm('outdated', '--global', resource[:name]).split('@', 1) # no idea what i'm doing
return outdated if outdated =~ /^(\d\.)+$/ # n.b.: this doesn't match builds, alpha's rcs, etc…
return @property_hash[:ensure] unless @property_hash[:ensure].is_a? Symbol # why? we could just to_s
# cuz otherwise this returns nil
end
|
merging this for now, thank you @juniorsysadmin! |
igalic
added a commit
that referenced
this pull request
Jan 7, 2016
WIP: Attempt to fix failng Rubocop lint checks
|
i'll do the rest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.