Add the ability to manage dependent packages else where. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwolf Would prefer that this uses |
|
I thought about that but I wanted it to be more clear that it was package dependencies. I am still happy to change it if you want me too. |
|
Puppet will pull in package dependencies via yum, apt etc so leaving package in the name might lead to confusion. |
| @@ -469,6 +469,12 @@ that were available on 2017-01-08: | |||
| The USE flags to use for the Node.js package on Gentoo systems. Defaults to | |||
| ['npm', 'snapshot']. | |||
|
|
|||
| #### `manage_dep_packages` | |||
There was a problem hiding this comment.
Make it clear in the README that this refers to requirements for an apt HTTPS repository, not nodejs itself.
|
@kwolf Status of this PR? |
|
Kinda superseded by #348 . Which might make it more difficult to solve your problem. Or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already manage one of the packages (
ca-certificates) elsewhere. This adds the ability to manage dependent packages outside of the nodejs module to avoid duplicate package definitions.