Set default value for $repo_pin to undef #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
force-pushed
the
fix-apt-pin
branch
from
59df01c
to
1d2958a
Compare
juniorsysadmin
commented
Nov 12, 2017
| @@ -5,7 +5,7 @@ | |||
| $nodejs_package_ensure = 'present' | |||
| $repo_enable_src = false | |||
| $repo_ensure = 'present' | |||
| $repo_pin = false | |||
| $repo_pin = undef | |||
There was a problem hiding this comment.
Not making this a data type for now as want to keep the diff small
juniorsysadmin
changed the title
juniorsysadmin
force-pushed
the
fix-apt-pin
branch
from
1d2958a
to
04ca73f
Compare
|
This change should continue to work with earlier 2/3 versions of soft dependency apt |
juniorsysadmin
force-pushed
the
fix-apt-pin
branch
2 times, most recently
from
4fd111a
to
81d99c4
Compare
juniorsysadmin
changed the title
alexjfisher
reviewed
Nov 12, 2017
spec/classes/nodejs_spec.rb
Outdated
| @@ -122,13 +122,13 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'and repo_pin not set' do | |||
There was a problem hiding this comment.
The original statement is probably more accurate. If you set something to undef, you're not actually setting it. The parameter default gets used (which happens to be undef).
puppetlabs/puppetlabs-apt#711 introduced data types in the apt module, and false is no longer a valid value for the apt::source $pin parameter Fixes voxpupuli#333
juniorsysadmin
force-pushed
the
fix-apt-pin
branch
from
81d99c4
to
15145ce
Compare
bastelfreak
approved these changes
Nov 13, 2017
alexjfisher
previously approved these changes
Nov 13, 2017
alexjfisher
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs/puppetlabs-apt#711 introduced data types in the apt module, and false is no longer a valid value for the apt::source $pin parameter
Fixes #333