fix 'nodejs::repo_ensure: absent' for yum #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, setting ensure to 'absent' results in creating two files in /etc/yum.repos.d: $ cat nodesource.repo [nodesource] $ cat nodesource-source.repo [nodesource-source] This results in yum failure: $ sudo yum check-update Loaded plugins: fastestmirror, security Repository 'nodesource-source' is missing name in configuration, using id Repository 'nodesource' is missing name in configuration, using id Loading mirror speeds from cached hostfile Error: Cannot find a valid baseurl for repo: nodesource It is better to ensure these files do not exist. The corresponding apt class is already set up this way. Note: I was unable to get local tests working for this module, but I see that there are automated tests; I will ensure they work.
|
I had a bit of trouble with the tests at first, but I think I got it straightened out. Please let me know if there is anything that needs fixing. Thanks, |
juniorsysadmin
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, setting ensure to 'absent' results in creating two files in
/etc/yum.repos.d:
$ cat nodesource.repo
[nodesource]
$ cat nodesource-source.repo
[nodesource-source]
This results in yum failure:
$ sudo yum check-update
Loaded plugins: fastestmirror, security
Repository 'nodesource-source' is missing name in configuration, using id
Repository 'nodesource' is missing name in configuration, using id
Loading mirror speeds from cached hostfile
Error: Cannot find a valid baseurl for repo: nodesource
It is better to ensure these files do not exist. The corresponding apt
class is already set up this way.
Note: I was unable to get local tests working for this module. Please
test before merging.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues