update list of tested OSes accordingly with metadata.json #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased version of GH-402 |
|
Debian/buster is already bringing NodeJS 10, so using 8.x as default will not work, as the package is not downgraded, leading to a test fail. Looking at https://nodejs.org/en/about/releases/ I'd even lean towards setting the default to 12.x. |
bastelfreak
reviewed
Jan 18, 2020
manifests/params.pp
Outdated
| @@ -11,7 +11,7 @@ | |||
| $repo_proxy_password = 'absent' | |||
| $repo_proxy_username = 'absent' | |||
| $repo_release = undef | |||
| $repo_url_suffix = '8.x' | |||
| $repo_url_suffix = '10.x' | |||
There was a problem hiding this comment.
is this change required? If so it qualifies as a backwards-incompatble change?
There was a problem hiding this comment.
|
Also consider updating the |
Done. |
dhoppe
approved these changes
Jan 21, 2020
juniorsysadmin
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues