Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs dev package name for Ubuntu 20.04 . #421 #422

Merged
merged 1 commit into from
May 1, 2020

Conversation

cliffano
Copy link
Contributor

Pull Request (PR) description

nodejs-dev package no longer exist for Ubuntu 20.04.
It has been replaced by libnode-dev .

This Pull Request (PR) fixes the following issues

Fixes #421

@mmoll
Copy link
Contributor

mmoll commented Apr 26, 2020

@cliffano The current Puppet 6 test failures are (AFAICT) unrelated, but could you also add Ubuntu 20.04 to the integration tests? See GH-413 for an example with EL 8.

Copy link
Member

@dhoppe dhoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this tested via .sync.yaml and .travis.yaml. Unfortunately camptocamp/facterdb does not support Ubuntu 20.04 at this time.

@mmoll
Copy link
Contributor

mmoll commented Apr 27, 2020

Aw, I see... There's also no puppet-agent package from PL at the moment.

@ekohl
Copy link
Member

ekohl commented Apr 30, 2020

#423 made master green again. Restarted the failed test to see if it passes.

@mmoll
Copy link
Contributor

mmoll commented May 1, 2020

I extended the tests, together with voxpupuli/facterdb#154 this is green now.

@ekohl ekohl merged commit b133542 into voxpupuli:master May 1, 2020
@ekohl
Copy link
Member

ekohl commented May 1, 2020

Thanks!

@cliffano
Copy link
Contributor Author

cliffano commented May 1, 2020

Thanks for merging. Sorry I've been busy the whole week, was planning to respond over the weekend.
Yes, I could only test package changes in 20.04 unfortunately, because as mentioned above, puppet-agent isn't ready yet. This is tracked on https://tickets.puppetlabs.com/browse/PA-3127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "Package 'nodejs-dev' has no installation candidate" on Ubuntu 20.04
4 participants