add parameter $manage_nodejs_package #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
manage-nodejs-package
branch
from
b059949
to
1251c08
Compare
kenyon
added a commit
to kenyon/puppet
that referenced
this pull request
Nov 1, 2020
While I wait for my features to be upstreamed: * voxpupuli/puppet-nodejs#431 * voxpupuli/puppet-nodejs#432
|
Found a problem with this, should be fixed shortly... |
kenyon
force-pushed
the
manage-nodejs-package
branch
from
1251c08
to
f6b2627
Compare
|
Looks good now. 🏁 |
bastelfreak
reviewed
Nov 2, 2020
Defaults to true. This allows for using this module without managing the nodejs package. The use case for this is where you want to use the npm package provider in this module, but otherwise have no need for directly installing nodejs. This patch allows for expressing that use case in your puppet code.
kenyon
force-pushed
the
manage-nodejs-package
branch
from
f6b2627
to
8716b16
Compare
kenyon
added
enhancement
bastelfreak
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to true. This allows for using this module without managing the nodejs package. The use case for this is where you want to use the npm package provider in this module, but otherwise have no need for directly installing nodejs. This patch allows for expressing that use case in your puppet code.