Add FreeBSD support #435
Merged
Add FreeBSD support #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we can't rely on our PATH, we're hosed anyway.
|
n.b.: I want to add tests to this… for all supported OSes… but OpenBSD & FreeBSD aren't supported right now anyway, so… |
bastelfreak
reviewed
Nov 16, 2020
since i don't know much about Windows, I'm leaving that as is for now. But in terms of escaping / testing, and consolidating! our testing, it would make sense to extend it to Windows as well.
bastelfreak
approved these changes
Nov 17, 2020
igalic
commented
Nov 17, 2020
thanks to @bastelfreak for pointing this out
juniorsysadmin
approved these changes
Nov 17, 2020
igalic
commented
Nov 18, 2020
bastelfreak
approved these changes
Nov 18, 2020
|
this needs a better changelog entry, so we should at least change the title here: we now actually support FreeBSD, and it's metadata.json and as such it now has tests |
igalic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
if we can't rely on our PATH, we're hosed anyway.
This Pull Request (PR) fixes the following issues
Fixes #434