Fix precise - the logic on this was wrong.

[apenney]

We actually wanted to exclude precise, not include it.

[andrewshawcare]

Why is there conditional logic for precise at all? What's different about Precise that can't be stated for all Ubuntu releases?

[apenney]

We actually merged 7329919 which removed the special casing. As to why it was there, no idea.

[andrewshawcare]

I think there's two places (that I know of) where special consideration is given to Precise: When the apt repository is considered (line 41) and when the installation of NPM is considered (which this ticket addresses).

There should be an explanation of why precise was given special treatment in the first place and if no explanation can be found both areas should be removed.

Also, as the logic stands we have three cases where NPM will be installed:

• the operating system is ubuntu and the release is not precise
• the operating system is not ubuntu and the release is precise
• the operating system is not ubuntu and the release is not precise

Do we want to accept all of those conditions, or just:

• the operating system is ubuntu and the release is not precise

[andrewshawcare]

Ah, okay. That commit seems to remove both, not try and fix the logic (I was looking at the initial commits to this issue).

Brand new to the social side of Github. I apologize in advance for my complete lack of knowledge on how the comments work.

[andrewshawcare]

When do these changes move to the Puppet forge? I'm currently trying to bandage around the package and this fix would address the problem directly.

[apenney]

I'll try and get a release out today. I don't see any reason we can't, I need some time to trawl through the changes and get a changelog together and all that boring stuff but I can get that done this afternoon.

[andrewshawcare]

Awesome, thanks!

[apenney]

http://forge.puppetlabs.com/puppetlabs/nodejs/0.4.0

[rtgibbons]

I believe the logic for Precise was there to use Ubuntu's PPA for current distro's that had the latest; And then use ChrisLea's PPA on Precise since Ubuntu's default was locked in at 0.6.0.