Update to not require puppet apt module < 5.0

[meltingrobot]

Hi, having librarian barf out on this module when I'm trying to update the apt module the 5.0.1 due to this line in spec/spec_helper_acceptance.rb

install_module_from_forge('puppetlabs-apt', '>= 4.1.0 < 5.0.0') if fact('os.family') == 'Debian'

I need the newer apt module for Ubuntu 18.04.

[wyardley]

#714

[wyardley]

See my comments in #714 - are you sure this is the reason, though?

Also note that Ubuntu 18.04 is not currently listed in supported versions in the module's metadata anyway. I'm not sure if we're testing 18 in acceptance tests yet, but might make sense to submit a separate PR to add support for Ubuntu 18. It's possible that the module might need some other fixes for that, aside from metadata.

[meltingrobot]

The puppet server itself isn't getting updated to 18.04, we just need to update the apt module to handle 18.04 puppet clients.

[meltingrobot]

Link to the merged commit that adds support for 18.04 in the apt puppet module:

puppetlabs/puppetlabs-apt#769

[wyardley]

Right, but modules themselves list the OSes they support — in this case, it would apply to where you’re running the module, not to the puppet server itself

That’s not to say that the module will not work on Ubuntu 18, but it’s not currently listed as supported in the rabbitmq module, and we don’t test against it.

[wyardley]

I've merged #714 -- let me know if that changes anything.