[fix] ownership and permissions on conf files #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrower version of voxpupuli#796 * Set owner of config directories to rabbitmq user rather than root * Set group of config directories explicitly to rabbitmq, and set setgid bit * Set more restrictive permissions on the SSL directories * Update expectations, and test file permissions in acceptance tests
wyardley
commented
Apr 26, 2020
| it { is_expected.to be_directory } | ||
| it { is_expected.to be_owned_by 'rabbitmq' } | ||
| it { is_expected.to be_grouped_into 'rabbitmq' } | ||
| end |
There was a problem hiding this comment.
think this is the right place for these to live?
seems sensible to test these in the acceptance tests one way or another, I think, right?
dhoppe
approved these changes
Apr 26, 2020
bastelfreak
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is a narrower version of #796 (@dhoppe)
This does have some security implications, since when the file is owned by root, if the application is compromised, the rabbitmq user still may not be able to modify configuration files; with these changes, it would.
I believe that changing the ownership this way should be safe even on older RabbitMQ versions. However, would appreciate some eyes and / or actual testing of this, as I'm not in a good position to do extensive validations beyond the acceptance tests.
This Pull Request (PR) fixes the following issues
Fixes #703
Closes #796
Fixes #813