Fix Bug #804 'rabbitmqadmin will not be upgraded' #897
Conversation
|
Hi - thanks for the contribution Can you look at the formatting errors? There may be some expectations that also need to be updated. Also, can you make the subject / commit message not include the bug number, and instead explain the fix, maybe something along the lines of |
s-johansson
force-pushed
the
rabbitmqadmin_upgrade
branch
from
d0201d7
to
85f6419
Compare
kenyon
changed the title
s-johansson
force-pushed
the
rabbitmqadmin_upgrade
branch
3 times, most recently
from
9a1695f
to
2cff357
Compare
s-johansson
force-pushed
the
rabbitmqadmin_upgrade
branch
from
2cff357
to
3bd7612
Compare
|
@wyardley I was finally able to figure out the needed adjustments. I think, that's it. Happy new year 🍀 ! |
|
|
||
| Exec { 'remove_old_rabbitmqadmin_on_upgrade': | ||
| path => ['/bin','/usr/bin','/sbin','/usr/sbin'], | ||
| command => "rm ${rabbitmq::rabbitmq_home}/rabbitmqadmin", |
There was a problem hiding this comment.
Could we do this with a file resource with ensure => absent vs. using a shell exec (but still using the same onlyif)?
There was a problem hiding this comment.
I am aware, that exec resources should be avoided, if there is any possibilty to fullfil the task as well with other basically idempotent resources. In order to provide idempotence for this exec resource, onlyif and refreshonly parameter are set.
Managing a file resource presence dependent on the refresh signal seems not to be possible imho.
Pull Request (PR) description
Add removal of rabbitmqadmin script and trigger refresh upon package upgrade or downgrade
This Pull Request (PR) fixes the following issues
Fixes #804