Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Puppet 4 and 5 support + daemon-reload code #171

Merged
merged 3 commits into from
Feb 23, 2021

Commits on Feb 18, 2021

  1. Drop Puppet 4 and 5 support

    This picks version 6.1.0 as a new lower bound since that contains code
    to automatically run daemon-reload if needed. Versions 4 and 5 are EOL.
    ekohl committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    12f609c View commit details
    Browse the repository at this point in the history
  2. Drop daemon-reload code

    Since Puppet 6.1.0 it's no longer needed to run daemon-reload manually
    when restarting a service. That means it's possible to drop this code.
    ekohl committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    a76a4b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Implement a workaround for PUP-9473.

    Prior to this commit, the follow code did not suffer from PUP-9473:
    
        systemd::unit_file { 'myservice.service':
          ensure => absent,
          active => true,
        }
    
    That's because the module considers that an invalid state and fails to
    compile.
    
    The follow code did trigger the bug:
    
        systemd::unit_file { 'myservice.service':
          ensure => absent,
        }
    
        service { 'myservice':
          ensure  => running,
          require => Systemd::Unit_file['myservice.service'],
        }
    
    That's precisely what happens when a module switches from a
    module-provided unit file to a package-provided unit file.
    ekohl committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    deaf035 View commit details
    Browse the repository at this point in the history