Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 #102

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Add Debian 12 #102

merged 3 commits into from
Oct 18, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 25, 2023

No description provided.

@@ -32,6 +32,7 @@ class OperatingSystem
# https://wiki.debian.org/DebianReleases
'Debian' => {
# TODO: EOL is standard support, not the extended life cycle
'12' => nil, # '~2026',
'11' => nil, # '~2024',
'10' => nil, # '~2022',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, 10 is EOL by now. should we add the date now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we should do that in another PR (actually it was 2022-09-10 and we missed it) :D
https://endoflife.date/debian

@bastelfreak
Copy link
Member

In the past we waited with adding a new OS until puppet provides AIO packages for the platform. I don't mind adding Debian 12 already but then we need to ensure that we use the distro packages instead.

@evgeni
Copy link
Member Author

evgeni commented Sep 25, 2023

In the past we waited with adding a new OS until puppet provides AIO packages for the platform. I don't mind adding Debian 12 already but then we need to ensure that we use the distro packages instead.

They still… Okay…

How do I tell it to use distro packages, is that even in this repo? Do I really want to know?

@ekohl
Copy link
Member

ekohl commented Sep 27, 2023

It is in this repository: 0dcad53 is how it was done for Arch Linux.

It was in my wish list to support this at some point. We probably need some special casing here:

majors.each do |puppet_version|
if AIO.has_aio_build?(os, release, puppet_version[:value]) # rubocop:disable Style/IfUnlessModifier
yield [os, release, puppet_version]
end
end

We probably need something for Fedora too there.

@ekohl
Copy link
Member

ekohl commented Oct 7, 2023

We probably need something for Fedora too there.

#104 does that. And I've taken the liberty of taking your PR and rebase it on top of it, doing the same for Debian 12.

@ekohl
Copy link
Member

ekohl commented Oct 7, 2023

Testing it out in voxpupuli/puppet-example#37.

@ekohl
Copy link
Member

ekohl commented Oct 13, 2023

It includes #104 but Fedora actually has an issue where puppet-agent isn't available, just puppet.

# The operating system release version
#
# @return [Optional[Integer]] The Puppet major version, if any
def os_release_puppet_version(operatingsystem, release)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo for me: add arch linux here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's rolling I'm not sure if that's desirable.

ekohl and others added 3 commits October 16, 2023 15:11
When there is no AIO build available, it is possible to test the OS
using the distribution provided package.

Since these aren't rolling releases, it includes the Puppet version in
the context. Not in the name, to keep it consistent.
While there aren't any AIO builds, this allows testing the platform.
@ekohl
Copy link
Member

ekohl commented Oct 17, 2023

@ekohl ekohl merged commit ff57b5e into master Oct 18, 2023
6 checks passed
@ekohl ekohl deleted the add-debian-12 branch October 18, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants