Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing 'ß' to GermanSequenceData #153

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: add missing 'ß' to GermanSequenceData #153

merged 1 commit into from
Aug 5, 2024

Conversation

Gregor-Gottschewski
Copy link
Contributor

@Gregor-Gottschewski Gregor-Gottschewski commented Aug 1, 2024 •
edited
Loading

The 'ß' (Eszett) follows the '0' on the German keyboard layout

Reference:

KB_Germany

@dfish3r dfish3r self-assigned this Aug 5, 2024
@dfish3r
Copy link
Member

dfish3r commented Aug 5, 2024

Thank you for the patch!

@dfish3r dfish3r merged commit 8b0a117 into vt-middleware:main Aug 5, 2024
dfish3r added a commit that referenced this pull request Oct 4, 2024
@dfish3r
Remove invalid character from sequence.
118c330 
Issue #153 should have removed the backslash character when the Eszett was added.
Add unit test to confirm the correctness of character sequences.
Fixes #162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dfish3r dfish3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gregor-Gottschewski @dfish3r