-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When scaffolding new app, TypeScript Error in vitest.config.ts #313
Labels
bug
Something isn't working
Comments
haoqunjiang
added a commit
to haoqunjiang/vite
that referenced
this issue
Jul 11, 2023
Fixes compatibility with `mergeConfig`, as reported in vuejs/create-vue#313 Before the change, `defineConfig` would return `UserConfigExport`, which is a union type. This would cause `mergeConfig` to fail, as it doesn't accept the `UserConfigFn` type in the union. (vitejs#13135) After the change, `defineConfig` returns the same type that it receives, so it would exclude `UserConfigFn` from the return type whenever possible.
9 tasks
haoqunjiang
added a commit
to haoqunjiang/vitest
that referenced
this issue
Jul 24, 2023
Ported from vitejs/vite#13792 Fully fixes issues like vuejs/create-vue#317 and vuejs/create-vue#313 For an easy reproduction, please refer to https:/sodatea/viteste-define-config-bug-repro I didn't include a test in this PR because: 1. The reproduction is a bit complicated, it only fails on the very latest Vite versions, but updating Vite would mess up the lockfile. 2. By not updating the dependencies, we can make sure that this fix is compatible with older versions of Vite, too.
Workaround:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When scaffolding a new app with TypeScript and Vitest using
npm init vue@latest
, there's a TypeScript error in vitest.config.ts related with the usage of mergeConfig.It seems the actual types in use for the "mergeConfig" arguments are UserConfigExport, but "mergeConfig" is expecting them to be of type UserConfig.
Here are the prompt selections:
After installing dependencies, the following error shows up in vitest.config.ts:
The text was updated successfully, but these errors were encountered: