fix(tsc): improve regexp performance for global type removal #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with the removal of global types was the RegExp, for certain files written like `.tsbuildinfo` which is a single line long contents file it would scan the whole line scanning for the characters. By specifying `m` flag it causes ^ and $ to match the begin/end of each line (not only begin/end of string). This removes the need for the check of the filename to do the replacement check.
blake-newman
force-pushed
the
blake.newman/fix-regexp
branch
from
a5be536
to
7a3d615
Compare
rchl
reviewed
Apr 12, 2024
| @@ -65,7 +58,7 @@ export function run() { | |||
| } | |||
| } | |||
|
|
|||
| const removeEmitGlobalTypesRegexp = /[^\n]*__VLS_globalTypesStart[\w\W]*__VLS_globalTypesEnd[^\n]*\n/g; | |||
| const removeEmitGlobalTypesRegexp = /^[^\n]*__VLS_globalTypesStart[\w\W]*__VLS_globalTypesEnd[^\n]*\n?$/mg; | |||
There was a problem hiding this comment.
I think those initial/trailing \n make no sense with m flag. Those should be ignored anyway when matching with m flag.
Suggested change
| const removeEmitGlobalTypesRegexp = /^[^\n]*__VLS_globalTypesStart[\w\W]*__VLS_globalTypesEnd[^\n]*\n?$/mg; | |
| const removeEmitGlobalTypesRegexp = /^.*__VLS_globalTypesStart[\w\W]*__VLS_globalTypesEnd.*$/mg; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the removal of global types was the RegExp, for certain files written like
.tsbuildinfowhich is a single line long contents file it would scan the whole line scanning for the characters.By specifying
mflag it causes^and$to match the begin/end of each line (not only begin/end of string).This removes the need for the check of the filename to do the replacement check.