Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extentions to settings #2759

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lzl124631x
Copy link

No description provided.

Copy link
Member

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some documents?

@@ -140,7 +141,8 @@ export function getDefaultVLSConfig(): VLSFullConfig {
},
experimental: {
templateInterpolationService: false
}
},
extensions: []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can call alias.extensions

@@ -35,6 +36,7 @@ export function createEnvironmentService(
getPackagePath: () => packagePath,
getVueVersion: () => inferVueVersion(packagePath),
getSnippetFolder: () => snippetFolder,
getGlobalComponentInfos: () => globalComponentInfos
getGlobalComponentInfos: () => globalComponentInfos,
isVueFile: (path: string) => ['.vue', ...$config.vetur.extensions].some(ext => path.endsWith(ext))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to prefix . when no dot input.

@lzl124631x
Copy link
Author

Can you add some documents?

Sure. But do we still need this change? This was originally for #2753.

@yoyo930021
Copy link
Member

Can you add some documents?

Sure. But do we still need this change? This was originally for #2753.

In this comment #2753 (comment) ,
Uni-app can use this PR. Of course if merge this PR, I can't disallow to use another extension.
But I think as long as it's stated in the document, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants