Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs types for vue-rx #52

Closed
TonyPythoneer opened this issue Aug 11, 2017 · 3 comments
Closed

Needs types for vue-rx #52

TonyPythoneer opened this issue Aug 11, 2017 · 3 comments

Comments

@TonyPythoneer
Copy link

Would you make typings.json for this repo?

@regou
Copy link
Collaborator

regou commented Aug 11, 2017

This is deprecated after ts2 I suppose? Install @type namespaced repo instead now.
vue-rx itself don't expose any method, in this case not sure how much we can benefit from safe-typing it
Maybe you can provide other vue plugin examples that meant to be corporate with ts projects.
And pull requests are welcomed.

@oliverw
Copy link

oliverw commented Sep 11, 2017

This is deprecated after ts2 I suppose? Install @type namespaced repo instead now.

No, it is not. @types/<something> isn't automagically created. Someone has to author it and push it to NPM. The recommended way is to ship a index.d.ts with your library.

vue-rx itself don't expose any method

$watchAsObservable is not a method?

@oliverw
Copy link

oliverw commented Sep 12, 2017

Great work as usual. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants