Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1813 #1817

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix #1813 #1817

merged 1 commit into from
Apr 7, 2021

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Apr 6, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

const componentInstance = isFunctionalSelector
? node[FUNCTIONAL_OPTIONS]
: node.child
const componentInstance = node[FUNCTIONAL_OPTIONS] || node.child
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the line you removed was for back compat. You might need to skip the failing test. Are you able to update the PR and fix the failing test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just skip this test for vue < 2.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I find no way to throw exception in this case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's probably fine, go for it. I think most people will be on at least 2.5 by now.

@lmiller1990
Copy link
Member

Thanks for this!

@Djaler Djaler force-pushed the fix/find-functional-component branch 2 times, most recently from c3db9b2 to 784211a Compare April 7, 2021 06:38
@Djaler Djaler force-pushed the fix/find-functional-component branch from 784211a to ba86ef3 Compare April 7, 2021 06:40
@lmiller1990 lmiller1990 merged commit 3cd81d0 into vuejs:dev Apr 7, 2021
@lmiller1990 lmiller1990 mentioned this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants