Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mutation and action payload optional in definition file #1517

Merged
merged 2 commits into from
Mar 10, 2019

Conversation

davidsandoz
Copy link
Contributor

When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.

This PR simply makes the payload optional.

Fixes #1491

When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.

This PR simply makes the payload optional.

Fixes vuejs#1491
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
Please make the same change for action payload 🙂

@davidsandoz davidsandoz changed the title Make mutation payload optional in definition file Make mutation and action payload optional in definition file Mar 9, 2019
@davidsandoz
Copy link
Contributor Author

@ktsn, change for action payload is now done as well.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ktsn ktsn merged commit 0e109e2 into vuejs:dev Mar 10, 2019
vaga pushed a commit to vaga/vuex that referenced this pull request Apr 20, 2020
…ile (vuejs#1517)

* Make mutation payload optional in definition file

When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.

This PR simply makes the payload optional.

Fixes vuejs#1491

* Make action payload optional in definition file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants