chore(core): improve type comments and replace internal with private #531
Annotations
3 errors and 4 notices
|
E2E test (base /e2e/):
e2e/tests/hmr.spec.ts#L91
1) [chromium] › hmr.spec.ts:79:3 › should update title correctly ─────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected)
Locator: locator(':root')
Expected pattern: /Updated Title/
Received string: "HMR Title | VuePress E2E"
Call log:
- expect.toHaveTitle with timeout 5000ms
- waiting for locator(':root')
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
- locator resolved to <html lang="en-US">…</html>
- unexpected value "HMR Title | VuePress E2E"
89 | await expect(renderedTitleLocator).toHaveText('HMR Title')
90 | await hmrUpdateTitle()
> 91 | await expect(page).toHaveTitle(/Updated Title/)
| ^
92 | await expect(titleLocator).toHaveText('Updated Title')
93 | await expect(renderedTitleLocator).toHaveText('Updated Title')
94 | })
at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:91:24
|
|
E2E test (base /):
e2e/tests/hmr.spec.ts#L87
1) [chromium] › hmr.spec.ts:79:3 › should update title correctly ─────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected)
Locator: locator(':root')
Expected pattern: /HMR Title/
Received string: ""
Call log:
- expect.toHaveTitle with timeout 5000ms
- waiting for locator(':root')
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
85 | await page.goto('hmr/title.html')
86 |
> 87 | await expect(page).toHaveTitle(/HMR Title/)
| ^
88 | await expect(titleLocator).toHaveText('HMR Title')
89 | await expect(renderedTitleLocator).toHaveText('HMR Title')
90 | await hmrUpdateTitle()
at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:87:24
|
|
E2E test (base /):
e2e/tests/hmr.spec.ts#L122
2) [chromium] › hmr.spec.ts:96:3 › should update content and frontmatter and title correctly after navigation
Error: Timed out 5000ms waiting for expect(locator).toHaveTitle(expected)
Locator: locator(':root')
Expected pattern: /HMR Title/
Received string: ""
Call log:
- expect.toHaveTitle with timeout 5000ms
- waiting for locator(':root')
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
- locator resolved to <html lang="en">…</html>
- unexpected value ""
120 | // start from title page
121 | await page.goto('hmr/title.html')
> 122 | await expect(page).toHaveTitle(/HMR Title/)
| ^
123 | await expect(titleLocator).toHaveText('HMR Title')
124 | await expect(renderedTitleLocator).toHaveText('HMR Title')
125 |
at /Users/runner/work/core/core/e2e/tests/hmr.spec.ts:122:24
|
|
E2E test (base /e2e/)
1 flaky
[chromium] › hmr.spec.ts:79:3 › should update title correctly ──────────────────────────────────
70 passed (28.9s)
|
|
E2E test (base /e2e/)
67 passed (16.7s)
|
|
E2E test (base /)
2 flaky
[chromium] › hmr.spec.ts:79:3 › should update title correctly ──────────────────────────────────
[chromium] › hmr.spec.ts:96:3 › should update content and frontmatter and title correctly after navigation
69 passed (38.7s)
|
|
E2E test (base /)
67 passed (18.9s)
|
Loading