-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"once" in event listener option #1
Labels
T: enhancement
Functionality that enhances existing features
Comments
johnleider
added
the
T: enhancement
Functionality that enhances existing features
label
Dec 14, 2016
Resolved with commit b369f0. |
Closed
johnleider
pushed a commit
that referenced
this issue
Oct 2, 2018
Added Serbian cyrilic translation.
KaelWD
pushed a commit
that referenced
this issue
Oct 28, 2018
i18n Hookup, Homepage, Component Doc Component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have noticed that here L72 you're using
once
option in addEventListener function. The thing is. This option is not well supported as you can see here - http://caniuse.com/#feat=once-event-listener so in many browsers, added event listeners like this are not going to remove themselves, so you're going to have memory leak right there. It's worth to refactor.The text was updated successfully, but these errors were encountered: