Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.1.3] rounded=false doesn't work #16601

Closed
Maxim-Mazurok opened this issue Feb 7, 2023 · 6 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Closed

[Bug Report][3.1.3] rounded=false doesn't work #16601

Maxim-Mazurok opened this issue Feb 7, 2023 · 6 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Assignees
Labels
C: VBtn VBtn T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Maxim-Mazurok
Copy link
Contributor

Maxim-Mazurok commented Feb 7, 2023

Environment

Vuetify Version: 3.1.3
Vue Version: 3.2.47
Browsers: Chrome 109.0.0.0
OS: Windows 10

Steps to reproduce

Use <vBtn rounded={false}/> - won't work because border-radius is only disabled when rounaded strictly equals to zero, see

Expected Behavior

false works just like 0 (zero)

Actual Behavior

false doesn't work

Reproduction Link

https://play.vuetifyjs.com/#...

@taozhiyu
Copy link

taozhiyu commented Feb 14, 2023

According to the documentation, you should use rounded="0"

Well, you're right, the documentation says that Boolean values are supported

https://next.vuetifyjs.com/en/api/v-btn/#props-rounded

@Maxim-Mazurok
Copy link
Contributor Author

Well, you're right, the documentation says that Boolean values are supported

next.vuetifyjs.com/en/api/v-btn/#props-rounded

Exactly, and the default value in docs is false, but undefined in the actual code:

@santiagoaloi santiagoaloi self-assigned this Feb 24, 2023
@santiagoaloi santiagoaloi added C: VBtn VBtn pending review The issue is still pending disposition labels Feb 24, 2023
@santiagoaloi
Copy link
Member

santiagoaloi commented Feb 24, 2023

<vBtn rounded={false}/> that isn't a valid Vue syntax.

:rounded="false" shouldn't be used much really, as it's the default value.
I don't believe false and 0 are meant to do the same thing.

0 is no radius, however false seems to imply don't set any border radius, leave the default radius value.

I will confirm this with the rest of the team shortly.

@Maxim-Mazurok
Copy link
Contributor Author

Maxim-Mazurok commented Feb 25, 2023

<vBtn rounded={false}/> that isn't a valid Vue syntax.

This is a valid Vue JSX syntax

I don't believe false and 0 are meant to do the same thing.

I can kinda see this now... However, I was reading it as rounded=false meaning that "button is rounded" is a false statement

I will confirm this with the rest of the team shortly.

Thank you :) It may be just a docs fix to clear the confusion...

@santiagoaloi
Copy link
Member

After bringing this up with the team, false should act as 0 , but this is a buggy behavior, the intention is to remove the false prop value and leave the default as undefined.

@santiagoaloi santiagoaloi added the T: bug Functionality that does not work as intended/expected label Feb 25, 2023
@viT-1
Copy link

viT-1 commented Aug 24, 2023

Also defaults in global configuration prop "rounded: 0" does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment