Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.5.13] VTimePicker ends drag on area-leave #19508

Closed
KIDS-interactive opened this issue Mar 28, 2024 · 3 comments · Fixed by #19523
Closed

[Bug Report][3.5.13] VTimePicker ends drag on area-leave #19508

KIDS-interactive opened this issue Mar 28, 2024 · 3 comments · Fixed by #19523
Assignees
@blalan05
Labels
C: VTimePicker VTimePicker labs pending team review The issue is pending a full team review T: enhancement Functionality that enhances existing features working as intended The issue is working as intended
Milestone
v3.5.x

Comments

@KIDS-interactive
Copy link

Environment

Vuetify Version: 3.5.13
Vue Version: 3.4.21
Browsers: Chrome 123.0.0.0
OS: Windows 10

Steps to reproduce

Start to drag and leave the clock on dragging

Expected Behavior

it should be possible to change the clock-input while dragging outside - just check if the pointerdown-event starts in the clock itself

Actual Behavior

the input stops if i leave to clock on drag
v-time-picker-drag

Reproduction Link

https://play.vuetifyjs.com/#...
@blalan05
Copy link
Member

This matches V2 behavior.

@blalan05 blalan05 added T: enhancement Functionality that enhances existing features pending team review The issue is pending a full team review working as intended The issue is working as intended C: VTimePicker VTimePicker labs labels Mar 29, 2024
@b-maslennikov
Copy link

@blalan05 this does not match material design specs
https://m3.material.io/components/time-pickers/overview
try to set time on android device. this is how it should behave

@blalan05
Copy link
Member

blalan05 commented Mar 30, 2024 •
edited
Loading

The current implementation is using mouse/touch events on clock circle, which no longer fire when the mouse leaves that element. I believe you would have to create a window event listener and destroy it after to make what you want work. PRs welcome.

@blalan05 blalan05 linked a pull request Apr 1, 2024 that will close this issue
fix(VTimePicker): use window events instead of element #19523
Merged
johnleider pushed a commit that referenced this issue Apr 9, 2024
@blalan05
fix(VTimePicker): use window events instead of element (#19523)
73c3fb4 
fixes #19508
@johnleider johnleider added this to the v3.5.x milestone Apr 9, 2024
@aniketmaurya aniketmaurya mentioned this issue May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blalan05 blalan05

Labels
C: VTimePicker VTimePicker labs pending team review The issue is pending a full team review T: enhancement Functionality that enhances existing features working as intended The issue is working as intended
Projects
None yet
Milestone
v3.5.x
4 participants
@johnleider @b-maslennikov @blalan05 @KIDS-interactive