Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.6.1] VCarouselItem and content-class #19729

Closed
thany opened this issue May 1, 2024 · 0 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1315 or LLotme/esp-idf#19 · May be fixed by LLotme/esp-idf#5, LLotme/esp-idf#12 or YoutacRandS-VA/desec-stack#2
Assignees
Labels
C: VResponsive VResponsive T: bug Functionality that does not work as intended/expected
Milestone

Comments

@thany
Copy link

thany commented May 1, 2024

Environment

Vuetify Version: 3.6.1
Vue Version: 3.4.26
Browsers: Firefox 125.0
OS: Windows 10

Steps to reproduce

Try putting a content-class as object/array on a v-carousel-item.

Expected Behavior

The typing for content-class match the actual implementation.

Actual Behavior

While the content-class does correctly carry the class over to the v-responsive__content, the typings require it to be a string. So ignoring the typescript error, it does actually work, which is weird.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

If the current typing string is genuinely correct, we're going to need a way to serialise an object/array of classes into the string that it wants. I have not found an exported function in Vue that provides that functionality. Besides, it'd be good for consistency if all "class-ish" props have the same typings.

@KaelWD KaelWD added the T: bug Functionality that does not work as intended/expected label May 7, 2024
@github-actions github-actions bot removed the S: triage label May 7, 2024
@KaelWD KaelWD added the C: VResponsive VResponsive label May 7, 2024
@KaelWD KaelWD self-assigned this May 7, 2024
@KaelWD KaelWD added this to the v3.6.x milestone May 7, 2024
@KaelWD KaelWD closed this as completed in 8f0322d May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment