Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTabs): render tabs correctly using items #19868

Merged
merged 1 commit into from
May 29, 2024

Conversation

lzl0304
Copy link
Contributor

@lzl0304 lzl0304 commented May 23, 2024

Description

fixes #19855

Markup:

<template>
  <v-app>
    <v-container>
      <v-tabs v-model="value">
        <v-tab :value="1">A</v-tab>
        <v-tab :value="2">B</v-tab>
        <v-tab :value="3">C</v-tab>
      </v-tabs>

      <v-divider class="my-8" />

      <v-tabs v-model="value" :items="items" />
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const value = ref(2)
  const items = [
    { text: 'A', value: 1 },
    { text: 'B', value: 2 },
    { text: 'C', value: 3 },
  ]
</script>

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VTabs VTabs labels May 27, 2024
@johnleider
Copy link
Member

I double checked cypress locally and all specs passed.

@johnleider johnleider added this to the v3.6.x milestone May 29, 2024
@johnleider johnleider merged commit f5f2fa4 into vuetifyjs:master May 29, 2024
9 of 10 checks passed
@lzl0304 lzl0304 deleted the fix-19855 branch June 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTabs VTabs T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.7] VTabs no text shown with items prop
3 participants