Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Make tabs match material spec better #2530

Closed
KaelWD opened this issue Nov 16, 2017 · 5 comments
Closed

[Feature Request] Make tabs match material spec better #2530

KaelWD opened this issue Nov 16, 2017 · 5 comments
Assignees
@johnleider
Labels
T: enhancement Functionality that enhances existing features
Milestone
v1.0.0

Comments

@KaelWD
Copy link
Member

KaelWD commented Nov 16, 2017 •
edited
Loading

The tabs do not currently match the material specification and are rather difficult to use on mobile and narrow browser windows.

In particular, the side margins need to be looked at:
image

Also see the discussion in #1789 and #1749

https://material.io/guidelines/components/tabs.html#

yeah, I didn't use the template. Sue me
@KaelWD KaelWD added the T: enhancement Functionality that enhances existing features label Nov 16, 2017
@KaelWD KaelWD added this to the v1.0.0 milestone Nov 16, 2017
@KaelWD KaelWD mentioned this issue Nov 16, 2017
Closed
@nekosaur
Copy link
Member

Consider yourself sued!

@BennyAlex
Copy link

BennyAlex commented Nov 17, 2017 •
edited
Loading

@nekosaur @KaelWD
Another missing feature of the tabs is a working menu like this:
unbenannt324
I really need this feature for the new application for my company. Do you think you can implement this?

@KaelWD
Copy link
Member Author

KaelWD commented Nov 17, 2017

Create a new feature request for that, it's outside the scope of this issue.

@nekosaur
Copy link
Member

nekosaur commented Nov 17, 2017 •
edited
Loading

That is also already possible. See example #7 on docs.

@johnleider johnleider self-assigned this Nov 23, 2017
@johnleider johnleider mentioned this issue Dec 15, 2017
Closed
@johnleider johnleider mentioned this issue Dec 26, 2017
Merged
This was referenced Apr 5, 2019
Closed
Closed
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
4 participants
@nekosaur @johnleider @KaelWD @BennyAlex