Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VAutocomplete): port to v3 #14728

Merged
merged 17 commits into from
Feb 25, 2022
Merged

feat(VAutocomplete): port to v3 #14728

merged 17 commits into from
Feb 25, 2022

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Feb 16, 2022

Description

Port v-autocomplete to v3.

TODO

  • fix no-data-text
  • add the following properties
    • deletable-chips (renamed to closable-chips)
    • eager
    • hide-no-data
    • auto-select-first (pending keyboard support)
    • cache-items (removed)
    • disable-lookup (v-select only)
    • hide-spin-buttons (not relevant to v-autocomplete)
    • no-filter (pending update to filter composable)
    • small-chips (using density

KNOWN ISSUES

  • selection during filter when using the multiple prop drops missing items

How Has This Been Tested?

n/a

Markup:

<template>
  <v-app>
    <v-main>
      <div class="ma-4 pa-4">

        <div>
          Search: <pre>{{ JSON.stringify(search, null, 2) }}</pre>
        </div>

        <div>
          Model: <pre>{{ JSON.stringify(model2, null, 2) }}</pre>
        </div>

        <br>
        <br>

        <v-autocomplete
          v-model:search="search"
          v-model="model2"
          label="Autocomplete"
          :items="items"
        />

        <!-- <v-select
          v-model="model"
          label="Select"
          :items="items"
        />

        <v-text-field
          v-model="model"
          label="Textfield"
        /> -->
        <!-- <v-autocomplete
          key="what"
          v-model:search="search"
          v-model="model"
          open-on-click
          label="Autocomplete"
          :items="items"
          multiple
          clearable
        /> -->

        <!-- <v-select
          v-model="model"
          label="Select"
          :items="items"
          clearable
          multiple
        /> -->
      </div>
    </v-main>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      model: null,
      model2: 3,
      items: [
        // model 0 doesn't work at start
        // { title: 'One', value: 1 },
        // { title: 'Two', value: 2 },
        // { title: 'Three', value: 3 },
        // { title: 'Four', value: 4 },
        // { title: 'Five', value: 5 },
        // { title: 'Six', value: 6 },
        // { title: 'Foo', value: 1 },
        // { title: 'Bar', value: 2 },
        { title: 'Foobar', value: 3 },
        { title: 'Fizz', value: 4 },
        { title: 'Buzz', value: 5 },
        { title: 'Fizzbuzz', value: 6 },
      ],
      search: undefined,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider self-assigned this Feb 16, 2022
@johnleider johnleider added C: VAutocomplete VAutocomplete T: feature A new feature labels Feb 16, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Feb 16, 2022
@johnleider johnleider marked this pull request as ready for review February 22, 2022 18:13
@johnleider johnleider merged commit f99d19c into next Feb 25, 2022
@johnleider johnleider deleted the feat/v3-autocomplete branch February 25, 2022 19:19
@KaelWD KaelWD modified the milestones: v3.0.0-beta, v3.0.0 Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants