Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VInfiniteScroll): load event gets emitted endlessly even if status is empty #19764

Merged
merged 4 commits into from
May 7, 2024
Merged

fix(VInfiniteScroll): load event gets emitted endlessly even if status is empty #19764

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82fa43a
fix(VInfiniteScroll): dont emit load if status is empty
elkofy May 7, 2024
cac2388
Merge branch 'master' into fix/18895-VInfiniteScroll-keep-emiting-aft…
elkofy May 7, 2024
9fb2fba
Merge branch 'master' into fix/18895-VInfiniteScroll-keep-emiting-aft…
elkofy May 7, 2024
fd4bbe6
refactor(VInfiniteScroll): fix implementation
johnleider May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vuetify/src/components/VInfiniteScroll/VInfiniteScroll.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export const VInfiniteScroll = genericComponent<VInfiniteScrollSlots>()({
if (props.mode !== 'manual' && !isIntersecting.value) return

const status = getStatus(side)
if (!rootEl.value || status === 'loading') return
if (!rootEl.value || ['empty', 'loading'].includes(status)) return

previousScrollSize = getScrollSize()
setStatus(side, 'loading')
Expand Down
Loading