Update: fix inconsistency around aria-setsize=-1 #2341
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
separates out aria-setsize from aria-posinset and aria-level - as the existing requirement of what to do with a 0 or -1 value made sense for the latter two attributes, but is what is causing the inconsistency for aria-setsize. add new requirements for handling 0/-1 as an unknown/indeterminate size, and indicating user agents must not calculate a size if these values are used for setsize
MelSumner
reviewed
Sep 25, 2024
Co-authored-by: Melanie Sumner <[email protected]>
MelSumner
approved these changes
Oct 4, 2024
aleventhal
reviewed
Oct 4, 2024
scottaohara
commented
Oct 4, 2024
scottaohara
commented
Oct 4, 2024
|
talking with @aleventhal about this some more, we should also add in what to do about if someone uses the empty string, or puts in literal "garbage" text strings. So this can probably be |
I know this is going to happen in a follow-up, but it's probably good if it's not too strict, e.g. spaces before and after the number are ok. I was going to do the following:
|
aleventhal
reviewed
Oct 4, 2024
add that aria-setsize/posinset should also calculate value as if the attributes were not set, if they were provided the empty string. clarify that aria-setsize should return indeterminate for any value set that is not a positive whole number
scottaohara
commented
Oct 4, 2024
simplifying author's should back to just -1 for indeterminate. core aam / User agents will be where other values are accounted for.
aleventhal
requested changes
Oct 4, 2024
scottaohara
commented
Oct 9, 2024
aleventhal
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1759
closes #2346
also closes w3c/core-aam#149
This PR adjusts the requirements for
aria-setsizeto fix the inconsistency between the ARIA and CORE AAM specs regarding the use of-1as a value.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff