Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend parse tests with more use cases #134

Open
pellared opened this issue Apr 2, 2024 · 0 comments
Open

Extend parse tests with more use cases #134

pellared opened this issue Apr 2, 2024 · 0 comments
Assignees
@dyladan

Comments

@pellared
Copy link
Contributor

pellared commented Apr 2, 2024 •
edited
Loading

https:/w3c/baggage/blob/main/test/test_baggage.py can have more test cases added. Some can be taken from https:/open-telemetry/opentelemetry-go/blob/5449f083aa4af79313d5fe5fecd554af2cb7bbbc/baggage/baggage_test.go#L239.

This can help implementers of the baggage propagator to avoid some common issues. E.g.

  • + value should be a parsed to + (included in Go test cases)
  • %20 key should be parsed to %20 as keys are NOT percent encoded (NOT included in Go test cases)

CC @lachmatt @vishweshbankwar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyladan @pellared