New terminology: ClipboardItem "entry" as data type → value. #127
Conversation
lgarron
changed the title
Right now, the spec refers to two things as "items": - A list of `ClipboardItem`s. - The individual data values inside a single `ClipboardItem`. This is rather confusing, so this PR proposes to rename the latter to "entries", where an entry conceptually corresponds to a data type (e.g. `"text/string"`) that maps to a value (e.g. a Blob). This: - Matches the JS naming convention (think of `Object.entries`). - Does not change any spec semantics, only the names of some identifiers. In addition, this PR also renames: - `ClipboardItemDataType` → `ClipboardItemValue`, and - `ClipboardItemData` → `ClipboardItemValuePromise`. This matches the "entry is a type type mapping to a value" convention, and makes it clear what is a Promise. The previous names may have caused a semantic typo (w3c#126).
|
|
||
| [Exposed=Window] interface ClipboardItem { | ||
| constructor(record<DOMString, ClipboardItemData> items, | ||
| constructor(record<DOMString, ClipboardEntryValue> entries, |
There was a problem hiding this comment.
This change assumes that #126 is correct (e.g. matching Chrome's current behaviour). If this should accept Promises, then either:
- the record values should be
ClipboardEntryValuePromiseand Chrome's implementation should be changed, or - the record values should be allowed to be either
ClipboardEntryValueorClipboardEntryValuePromise.
|
FYI: my W3C affiliation is set to GitHub, Inc., but this my participation in this repo should be considered under my Chromium affiliation. I don't know if there's a way to tell the CI this. |
|
@lgarron the IPR issue has been fixed by @travisleithead and our Systeam. It will no longer be a blocker for future contributions. |
|
@lgarron: are you still working on this PR? The change itself is desirable, it just requires slight adaptation to match the current base. |
Yeah, I'd be glad to do that! Please give me a few days! 🙏 |
|
@lgarron: just to be sure, do you still intend adapting this patch soon? It would be valuable. |
|
@lgarron: can you please give an update if you still intend to adapt this patch? |
Right now, the spec refers to two things as "items":
ClipboardItems.ClipboardItem.This is rather confusing, so this PR proposes to rename the latter to
"entries", where an entry conceptually corresponds to a data type (e.g.
"text/string") that maps to a value (e.g. a Blob). This:Object.entries()).In addition, this PR also renames:
ClipboardItemDataType→ClipboardItemValue, andClipboardItemData→ClipboardItemValuePromise.This matches the "entry is a type mapping to a value" convention,
and makes it clear what is a Promise. The previous names may have caused
a semantic typo (#126).
Closes #????
The following tasks have been completed:
Implementation commitment:
Preview | Diff