[selectors-5] Add custom state pseudo-classes #8213

josepharhar · 2022-12-09T19:46:43Z

We resolved to add the custom state pseudo-classes to selectors 5 here: #4805

We resolved to add the custom state pseudo-classes to selectors 5 here: w3c#4805

josepharhar · 2022-12-09T19:47:33Z

I'm not sure how to link to the definition which will be added to the HTML spec and I'm not sure how much detail we should add, I started with the bare minimum

selectors-4/deferred-for-level-5

Co-authored-by: Keith Cirkel <[email protected]>

selectors-4/deferred-for-level-5

keithamus · 2023-12-24T10:29:52Z

selectors-4/deferred-for-level-5

+
+ The grammar of the '':state()'' pseudo-class is:
+
+ <pre class=prod>:state( <ident> )</pre>


Existing WPTs & impls make this case sensitive so:

Suggested change

<pre class=prod>:state( <ident> )</pre>

<pre class=prod>:state( <custom-ident> )</pre>

I suspect we don't want the exclusion of CSS-wide keywords that <custom-ident> implies; I think we have at least some amount of consensus that such exclusion was a bad idea in the first place and places that needed it should be using <dashed-ident> instead, and that <custom-ident> was a mistake. But on the other hand we should clearly document the case-sensitivity. I'm not sure what the current best practice is.

(I can't find any reference for this longer than #7431 (comment) but there might be a more detailed explanation somewhere.)

so should we do <dashed-ident> for now...? or keep it as <ident>?

<dashed-ident> is definitely wrong as this can take any ident. I suppose <ident> is right from a strictly grammar standpoint because, as @dbaron points out, it doesn’t exclude css wide keywords. <ident> claims case insensitivity though. Perhaps we could make a new token type here like <cased-ident>. Otherwise we should keep it as <ident> and either explain (or remove) the implementation handles cases discretely.

I'm not sure what is best here. @tabatkins can you advise?

I can’t find the reference to case insensitivity now.

The string given to customstateset can be dashed so should this be <ident> | <dashed-ident>?

No, <dashed-ident> is a subset of <ident>, so just <ident> is sufficient.

Ok so since i'm currently using <ident> can we merge this?

I think you should add a sentence saying it's case-sensitive. (unless @tabatkins disagrees, at least.)

I amended the first sentence to say that the argument is case sensitive

Co-authored-by: Keith Cirkel <[email protected]>

dbaron

This seems close to ready to merge, though I have a few comments below.

It's also not clear to me how useful this deferred-for-level-5 file is -- at some point we should have a real draft up on drafts.csswg.org.

(Did you make any attempt to run bikeshed on what you added here?)

selectors-4/deferred-for-level-5

dbaron · 2024-03-21T21:19:09Z

selectors-4/deferred-for-level-5

+
+ The grammar of the '':state()'' pseudo-class is:
+
+ <pre class=prod>:state( <ident> )</pre>


I think you should add a sentence saying it's case-sensitive. (unless @tabatkins disagrees, at least.)

astearns · 2024-03-26T00:26:20Z

@keithamus I am unclear why the agenda+ tag was added here (and we often miss tagged PRs for the agenda). If there is a question that needs resolving could you open an issue?

keithamus · 2024-03-26T10:56:29Z

I added it regarding #8213 (comment) but that has since been resolved. Apologies for the noise.

josepharhar · 2024-06-17T17:47:02Z

It's also not clear to me how useful this deferred-for-level-5 file is -- at some point we should have a real draft up on drafts.csswg.org.

Good point, I moved it to overview.bs

(Did you make any attempt to run bikeshed on what you added here?)

I just did and it works

dbaron · 2024-06-18T20:52:11Z

It's also not clear to me how useful this deferred-for-level-5 file is -- at some point we should have a real draft up on drafts.csswg.org.

Good point, I moved it to overview.bs

I don't think this is what we want either -- the resolution was to add to level 5, not to the (substantially more stable) level 4. We should probably get an actual selectors-5 draft going -- I'm not sure whether it should contain all or some or none of the material currently in the deferred-for-level-5 file.

(I admit that this makes getting the change landed more complicated!)

josepharhar · 2024-07-25T21:44:53Z

I don't think this is what we want either -- the resolution was to add to level 5, not to the (substantially more stable) level 4.

Thanks, I put it back in the deferred for level 5 file

We should probably get an actual selectors-5 draft going -- I'm not sure whether it should contain all or some or none of the material currently in the deferred-for-level-5 file.

What is the process for this? Can I do it in a separate PR?

dbaron · 2024-07-31T15:11:15Z

What is the process for this? Can I do it in a separate PR?

A separate PR would probably be good. I think it would make sense to move the deferred-for-level-5 file to be an actual level 5 draft. (Some of the material might need notes about its current state/status.)

josepharhar · 2024-08-05T23:30:58Z

A separate PR would probably be good. I think it would make sense to move the deferred-for-level-5 file to be an actual level 5 draft. (Some of the material might need notes about its current state/status.)

Great! Is there anything left to do to merge this?

…evel-5 file. As part of the resolution in #4805 and as a followup to #8213, this moves the deferred-for-level-5 file from the selectors-4 directory into a new selectors-5 delta spec.

Add custom state pseudo-classes

f65edc0

We resolved to add the custom state pseudo-classes to selectors 5 here: w3c#4805

This was referenced Dec 9, 2022

[selectors] Custom state pseudo class proposal #4805

Open

Add custom state pseudo class whatwg/html#8467

Merged

annevk requested review from tabatkins and fantasai January 11, 2023 09:43

josepharhar added 2 commits September 18, 2023 09:57

Merge branch 'main' into customstate

9ca9840

rename from :--foo to :state(foo)

c5cbcb2

keithamus reviewed Oct 31, 2023

View reviewed changes

selectors-4/deferred-for-level-5 Outdated Show resolved Hide resolved

keith's suggestion

6d86fd8

Co-authored-by: Keith Cirkel <[email protected]>

lukewarlow mentioned this pull request Nov 9, 2023

Adds CSSCustomState to schema webcomponents/custom-elements-manifest#128

Merged

keithamus reviewed Dec 24, 2023

View reviewed changes

selectors-4/deferred-for-level-5 Outdated Show resolved Hide resolved

keithamus reviewed Dec 24, 2023

View reviewed changes

add html reference

a31bd6a

Co-authored-by: Keith Cirkel <[email protected]>

keithamus added the Agenda+ label Feb 5, 2024

dbaron self-requested a review March 18, 2024 17:31

dbaron reviewed Mar 21, 2024

View reviewed changes

astearns removed the Agenda+ label Mar 26, 2024

josepharhar added 4 commits May 3, 2024 14:49

Say that argument is case sensitive

e243e60

rename custom-pseudo to custom-state

f2c7b40

move to overview.bs

d18d72f

fix html spec link

6d75e4f

josepharhar added 3 commits July 25, 2024 14:42

revert move to overview.bs and fix html spec link

d351d4a

re-do fix html spec link

a6150c8

Merge branch 'main' into customstate

1d07766

dbaron approved these changes Aug 13, 2024

View reviewed changes

dbaron merged commit 4ee0078 into w3c:main Aug 13, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[selectors-5] Add custom state pseudo-classes #8213

[selectors-5] Add custom state pseudo-classes #8213

josepharhar commented Dec 9, 2022

josepharhar commented Dec 9, 2022

keithamus Dec 24, 2023

dbaron Dec 24, 2023

josepharhar Jan 5, 2024

keithamus Jan 6, 2024

josepharhar Feb 5, 2024

keithamus Feb 6, 2024

tabatkins Feb 6, 2024

josepharhar Feb 6, 2024

dbaron Mar 21, 2024

josepharhar May 3, 2024

dbaron left a comment

dbaron Mar 21, 2024

astearns commented Mar 26, 2024

keithamus commented Mar 26, 2024

josepharhar commented Jun 17, 2024

dbaron commented Jun 18, 2024

josepharhar commented Jul 25, 2024

dbaron commented Jul 31, 2024

josepharhar commented Aug 5, 2024


		The grammar of the '':state()'' pseudo-class is:

		<pre class=prod>:state( <ident> )</pre>

	<pre class=prod>:state( <ident> )</pre>
	<pre class=prod>:state( <custom-ident> )</pre>

[selectors-5] Add custom state pseudo-classes #8213

[selectors-5] Add custom state pseudo-classes #8213

Conversation

josepharhar commented Dec 9, 2022

josepharhar commented Dec 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbaron left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astearns commented Mar 26, 2024

keithamus commented Mar 26, 2024

josepharhar commented Jun 17, 2024

dbaron commented Jun 18, 2024

josepharhar commented Jul 25, 2024

dbaron commented Jul 31, 2024

josepharhar commented Aug 5, 2024