Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trailing whitespace in mimetype file #1250

Closed
dauwhe opened this issue Mar 26, 2019 · 3 comments
Closed

trailing whitespace in mimetype file #1250

dauwhe opened this issue Mar 26, 2019 · 3 comments
Labels
Topic-OCF The issue affects the OCF section of the core EPUB 3 specification

Comments

@dauwhe
Copy link
Contributor

dauwhe commented Mar 26, 2019

In testing EPUBCheck 4.2, I found several errors on old EPUB 2 files around the mimetype. I tracked them down to mimetype files that contained a linebreak after the required string.

We are certainly less specific about trailing whitespace than leading whitespace. Should we mention this in the spec? Does this actually break the magic number?

Bad EPUB:

Screen Shot 2019-03-26 at 2 59 19 PM

Good EPUB:

Screen Shot 2019-03-26 at 2 59 28 PM
@dauwhe dauwhe added the Topic-OCF The issue affects the OCF section of the core EPUB 3 specification label Mar 26, 2019
@mattgarrish
Copy link
Member

I think epubcheck enforces this, but the spec should say no leading or trailing whitespace. One more reason to break up that awful run-together sentence of requirements.

@dauwhe
Copy link
Contributor Author

dauwhe commented Mar 26, 2019

@mattgarrish your wish is my command

#1206 (comment)

@mattgarrish mattgarrish mentioned this issue Mar 27, 2019
Merged
dauwhe added a commit that referenced this issue Mar 27, 2019
@dauwhe
Merge pull request #1251 from dauwhe/mimetype
89cb2c8 
update language around mimetype per #1206 and #1250
@dauwhe
Copy link
Contributor Author

dauwhe commented Mar 27, 2019

Closed via #1251

@dauwhe dauwhe closed this as completed Mar 27, 2019
rdeltour added a commit to w3c/epubcheck that referenced this issue Mar 29, 2019
@rdeltour
fix: check trailing spaces in mimetype file
82fe9cb 
See w3c/epub-specs#1250
@rdeltour rdeltour mentioned this issue Mar 29, 2019
Merged
rdeltour added a commit to w3c/epubcheck that referenced this issue Apr 5, 2019
@rdeltour
fix: check trailing spaces in mimetype file
123c69f 
See w3c/epub-specs#1250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic-OCF The issue affects the OCF section of the core EPUB 3 specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattgarrish @dauwhe