-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not report when linked resources are legit publication resources #1454
Labels
status: has PR
The issue is being processed in a pull request
type: false-positive
This issue is about valid content being incorrectly rejected
Milestone
Comments
rdeltour
added
status: accepted
Ready to be further processed
type: false-positive
This issue is about valid content being incorrectly rejected
labels
Dec 8, 2022
rdeltour
added a commit
that referenced
this issue
Dec 23, 2022
This commit checks that the linked resource is not in the spine before reporting `OPF-067` ("The resource "…" must not be listed both as a "link" element in the package metadata and as a manifest item."). Effectively, this allows package links to publication resources in the two cases identified in the EPUB 3.3 specification: > Resources referenced from the link element are publication resources > only when they are: > - referenced from the spine; or > - included or embedded in an EPUB content document Fix #1454
rdeltour
added
status: has PR
The issue is being processed in a pull request
and removed
status: accepted
Ready to be further processed
labels
Dec 23, 2022
rdeltour
added a commit
that referenced
this issue
Jan 3, 2023
This commit checks that the linked resource is not in the spine before reporting `OPF-067` ("The resource "…" must not be listed both as a "link" element in the package metadata and as a manifest item."). Effectively, this allows package links to publication resources in the two cases identified in the EPUB 3.3 specification: > Resources referenced from the link element are publication resources > only when they are: > - referenced from the spine; or > - included or embedded in an EPUB content document Fix #1454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: has PR
The issue is being processed in a pull request
type: false-positive
This issue is about valid content being incorrectly rejected
The spec says:
Currently, EPUBCheck reports
OPF-067
("The resource "…" must not be listed both as a "link" element in the package metadata and as a manifest item.") even for the two exceptions listed in the spec. For instance, spec example 33 (reference to a record embedded in an XHTML content document) is rejected by EPUBCheck.The text was updated successfully, but these errors were encountered: