Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncx pageTarget type not checked #761

Closed
mattgarrish opened this issue Jun 4, 2017 · 1 comment · Fixed by #762
Closed

ncx pageTarget type not checked #761

mattgarrish opened this issue Jun 4, 2017 · 1 comment · Fixed by #762
Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Milestone
4.1.0

Comments

@mattgarrish
Copy link
Member

As noted in the samples repository issues (IDPF/epub3-samples#11), the type attribute is not restricted to the values front, normal and special.

The rng definition is currently the very permissive:

			<attribute name="type">
				<text/>
			</attribute>

But should be an enumeration:

			<attribute name="type">
				<choice>
				    <value>front</value>
				    <value>normal</value>
				    <value>special</value>
				</choice>
			</attribute>
@tofi86 tofi86 self-assigned this Jun 4, 2017
@tofi86 tofi86 added this to the 4.1.0 milestone Jun 4, 2017
@tofi86 tofi86 added the type: bug The issue describes a bug label Jun 4, 2017
tofi86 added a commit that referenced this issue Jun 5, 2017
@tofi86
Update ncx.rng schema to add fixed list of pageTarget type values // f…
b2c9e93 
…ixes #761
@tofi86 tofi86 mentioned this issue Jun 5, 2017
Merged
@tofi86
Copy link
Collaborator

tofi86 commented Jun 5, 2017

Fixed in PullRequest #762. Please have a look.

@tofi86 tofi86 added the status: has PR The issue is being processed in a pull request label Jun 5, 2017
mattgarrish added a commit that referenced this issue Jun 5, 2017
@mattgarrish
Merge pull request #762 from IDPF/fix-761_ncx-pagetarget-type
54ff35b 
[fix #761] Update ncx.rng schema to add fixed list of pageTarget type values
@mpdunlop mpdunlop mentioned this issue Jun 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

[fix #761] Update ncx.rng schema to add fixed list of pageTarget type values w3c/epubcheck
2 participants
@tofi86 @mattgarrish