Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties attribute to link element #883

Closed
mattgarrish opened this issue Nov 12, 2018 · 3 comments
Closed

Add properties attribute to link element #883

mattgarrish opened this issue Nov 12, 2018 · 3 comments
Assignees
@rdeltour
Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed
Milestone
4.2.0-beta

Comments

@mattgarrish
Copy link
Member

The link element now allows properties attribute. The value(s) of the attribute must be prefixed unless they are defined in the link properties vocabulary.

Reference: https://w3c.github.io/publ-epub-revision/epub32/spec/epub-packages.html#sec-link-elem
@mattgarrish mattgarrish added the spec: EPUB 3.2 Impacting the support of EPUB 3.2 label Nov 12, 2018
@mattgarrish
Copy link
Member Author

See also #884 for more about the default vocabulary for this property.

@mattgarrish mattgarrish added the status: accepted Ready to be further processed label Nov 13, 2018
mattgarrish added a commit that referenced this issue Dec 17, 2018
@mattgarrish
Updates to the package schema for the following issues:
156df30 
- partially resolves #883 - only adds the attribute, doesn't check values
- fixes #882 - reports if a preceding itemref has a matching idref
- fixes #881 - reports presence of bindings
- fixes #880 - reports presence of rendition:viewport property in metadata
- fixes #879 - reports rendition:spread=portrait in metadata and rendition:spread-portrait on an itemref
- fixes #878 - reports presence of meta-auth property in metadata
- fixes #877 - reports presence of display-seq in metadata
- fixes #876 - reports if term/authority are not used together, or if multiple instances are attached to a single subject
@mattgarrish mattgarrish mentioned this issue Dec 17, 2018
Merged
rdeltour pushed a commit that referenced this issue Jan 14, 2019
@mattgarrish @rdeltour
feat: update the Package Document schema for EPUB 3.2
f834509 
- partially resolves #883 - only adds the attribute, doesn't check values
- fixes #882 - reports if a preceding itemref has a matching idref
- fixes #881 - reports presence of bindings
- fixes #880 - reports presence of rendition:viewport property in metadata
- fixes #879 - reports rendition:spread=portrait in metadata and rendition:spread-portrait on an itemref
- fixes #878 - reports presence of meta-auth property in metadata
- fixes #877 - reports presence of display-seq in metadata
- fixes #876 - reports if term/authority are not used together, or if multiple instances are attached to a single subject
rdeltour pushed a commit that referenced this issue Jan 14, 2019
@mattgarrish @rdeltour
feat: update the Package Document schema for EPUB 3.2
1f12512 
- partially resolves #883 - only adds the attribute, doesn't check values
- fixes #882 - reports if a preceding itemref has a matching idref
- fixes #881 - reports presence of bindings
- fixes #880 - reports presence of rendition:viewport property in metadata
- fixes #879 - reports rendition:spread=portrait in metadata and rendition:spread-portrait on an itemref
- fixes #878 - reports presence of meta-auth property in metadata
- fixes #877 - reports presence of display-seq in metadata
- fixes #876 - reports if term/authority are not used together, or if multiple instances are attached to a single subject
@rdeltour
Copy link
Member

Closed in #927

@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: accepted Ready to be further processed labels Jan 21, 2019
@rdeltour rdeltour reopened this Jan 21, 2019
@rdeltour
Copy link
Member

Oops. Forgot this was only partially resolved

@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: completed Work completed, can be closed labels Jan 21, 2019
@rdeltour rdeltour reopened this Jan 21, 2019
@rdeltour rdeltour self-assigned this Feb 5, 2019
@rdeltour rdeltour added this to the 4.2.0-beta milestone Feb 5, 2019
rdeltour added a commit that referenced this issue Feb 8, 2019
@rdeltour
feat: update Package vocabularies and link element checks
1741aee 
Fix #883, Fix #884, Fix #885, Fix #886

Vocabulary Changes:

- Declare the Package Document default vocabularies with their unique URIs
  - `meta` element properties: http://idpf.org/epub/vocab/package/meta/#
  - `link` element rel and properties: http://idpf.org/epub/vocab/package/link/#
  - `item` element properties: http://idpf.org/epub/vocab/package/item/#
  - `itemref` element properties: http://idpf.org/epub/vocab/package/itemref/#
- Define 'onix' and 'xmp' as the only valid unprefixed properties on
  `link` elements.
- Recognize 'acquire' and 'alternate' as valid link rel keywords.
- Deprecate the following link rel keywords: 'marc21xml-record',
  'mods-record', 'onix-record', 'xml-signature', and 'xmp-record'.

New messages:

- `OPF-089` (`ERROR`) is reported when the 'alternate' link rel keyword
  is not the only keyword in a `link` element `rel` attribute.
- Add replacement suggestions for deprecated link rel keywords (`OPF-086`).

Tests:

- add more tests on 'record' links.
- minimize various existing `link`-related tests.
rdeltour added a commit that referenced this issue Feb 8, 2019
@rdeltour
feat: update Package vocabularies and link element checks
99f882a 
Fix #883, Fix #884, Fix #885, Fix #886, Fix #887

Vocabulary Changes:

- Declare the Package Document default vocabularies with their unique URIs
  - `meta` element properties: http://idpf.org/epub/vocab/package/meta/#
  - `link` element rel and properties: http://idpf.org/epub/vocab/package/link/#
  - `item` element properties: http://idpf.org/epub/vocab/package/item/#
  - `itemref` element properties: http://idpf.org/epub/vocab/package/itemref/#
- Define 'onix' and 'xmp' as the only valid unprefixed properties on
  `link` elements.
- Recognize 'acquire' and 'alternate' as valid link rel keywords.
- Deprecate the following link rel keywords: 'marc21xml-record',
  'mods-record', 'onix-record', 'xml-signature', and 'xmp-record'.

New messages:

- `OPF-089` (`ERROR`) is reported when the 'alternate' link rel keyword
  is not the only keyword in a `link` element `rel` attribute.
- Add replacement suggestions for deprecated link rel keywords (`OPF-086`).

Tests:

- add more tests on 'record' links.
- minimize various existing `link`-related tests.
@rdeltour rdeltour mentioned this issue Feb 8, 2019
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team status: has PR The issue is being processed in a pull request labels Feb 8, 2019
@rdeltour rdeltour closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed
Projects
None yet
Milestone
4.2.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @mattgarrish