fix: wrong report of duplicate landmarks in Nav Doc #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeltour
added
the
status: needs review
The XPath in Schematron was using `@html:href` instead of `@href`, which faked the href equality test. This change also covers the case of multiple `epub:type` values. Fixes #926
rdeltour
force-pushed
the
fix/issue-926
branch
from
52174cb
to
b2b1706
Compare
rdeltour
added
status: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XPath in Schematron was using
@html:hrefinstead of@href,which faked the href equality test.
This change also covers the case of multiple
epub:typevalues.Fixes #926