Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report 3.x validation as following the EPUB 3.2 rules #943

Closed
rdeltour opened this issue Jan 17, 2019 · 3 comments
Closed

Report 3.x validation as following the EPUB 3.2 rules #943

rdeltour opened this issue Jan 17, 2019 · 3 comments
Assignees
@rdeltour
Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed type: bug The issue describes a bug
Milestone
4.2.0-beta

Comments

@rdeltour
Copy link
Member

It current says:

Validating using EPUB version 3.0.1 rules

Thanks for the catch @murata2makoto!
@rdeltour rdeltour added type: bug The issue describes a bug spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: accepted Ready to be further processed labels Jan 17, 2019
@rdeltour rdeltour self-assigned this Jan 17, 2019
@rdeltour rdeltour mentioned this issue Jan 17, 2019
Closed
@murata2makoto
Copy link
Contributor

Ishizu-san of Kadokawa pointed out this issue. We will continue to check epubcheck 4.2 for Japanese EPUB publiications.

@murata2makoto
Copy link
Contributor

murata2makoto commented Jan 18, 2019 •
edited
Loading

Ishizu-san has an interesting suggestion. He proposes that every added error/warning should be accompanied by the version number of the underlying EPUB specification.

Publishers often have to validate old publications using new epubcheck. This is for example because new ebook stores require that every publication passes epubcheck. Usually, such validation of past publications will lead to errors/warnings that were not issued before. If every error/warning indicates the version number of the underlying EPUB specification, it will become easier to handle such newly issued errors/warnings.

@rdeltour
Copy link
Member Author

rdeltour commented Feb 5, 2019

He proposes that every added error/warning should be accompanied by the version number of the underlying EPUB specification

The EPUB 3 CG decided in w3c/publ-cg#68 to not differentiate specification versions when checking EPUB 3.x publications. This question was asked specifically to avoid having to maintain a check-to-spec-version mapping (which would unfortunately not be as straightforward as it may seem) 😊

@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Feb 5, 2019
rdeltour added a commit that referenced this issue Feb 7, 2019
@rdeltour
feat: set reported 3.x version to "3.2"
9965c19 
Fix #943
@rdeltour rdeltour mentioned this issue Feb 7, 2019
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: in progress The issue is being implemented by the development team labels Feb 8, 2019
@rdeltour rdeltour added this to the 4.2.0-beta milestone Feb 8, 2019
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: has PR The issue is being processed in a pull request labels Feb 8, 2019
@rdeltour rdeltour closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
spec: EPUB 3.2 Impacting the support of EPUB 3.2 status: completed Work completed, can be closed type: bug The issue describes a bug
Projects
None yet
Milestone
4.2.0-beta
Development

No branches or pull requests
2 participants
@rdeltour @murata2makoto