Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not check entity references in comment or CDATA #949

Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix: do not check entity references in comment or CDATA #949

merged 1 commit into from
Jan 21, 2019

Conversation

rdeltour
Copy link
Member

  • suppress poorly implemented checks HTM-023 and HTM-024
    (entity references are already checked at parsing time)
  • add more tests for entity references

Fixes #800

@rdeltour
fix: do not check entity references in comment or CDATA
77bb1c3 
- suppress poorly implemented checks `HTM-023` and `HTM-024`
  (entity references are already checked at parsing time)
- add more tests for entity references

Fixes #800
@rdeltour rdeltour added the status: needs review Needs to be reviewed by a team member before further processing label Jan 21, 2019
@rdeltour rdeltour added this to the 4.1.1 milestone Jan 21, 2019
mattgarrish
mattgarrish approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@mattgarrish mattgarrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdeltour rdeltour merged commit 4307542 into master Jan 21, 2019
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: needs review Needs to be reviewed by a team member before further processing labels Jan 21, 2019
@rdeltour rdeltour deleted the fix/issue-800-entities branch January 21, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgarrish mattgarrish mattgarrish approved these changes

@tofi86 tofi86 Awaiting requested review from tofi86

@danielweck danielweck Awaiting requested review from danielweck

Assignees
No one assigned
Labels
status: completed Work completed, can be closed
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rdeltour @mattgarrish