Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The message for OPF_025 is confusing #959

Closed
rdeltour opened this issue Jan 25, 2019 · 0 comments
Closed

The message for OPF_025 is confusing #959

rdeltour opened this issue Jan 25, 2019 · 0 comments
Labels
spec: EPUB 3.x Impacting the support of EPUB 3.x specifications status: completed Work completed, can be closed type: improvement The issue suggests an improvement of an existing feature
Milestone
4.2.0-beta

Comments

@rdeltour
Copy link
Member

Error OPF_025 is raised when a property value is set to a list of term, when the related property only accepts a single term. All this is done in VocabUtil when parsing the value of the property-setting attribute.

The reported message says:

Property '%1$s' can take only one value.

where the thing between quotes is the actual property value.

This is confusing, I suggest replacing it with:

Property value list 'onix:codelist5 invalid' is not allowed, only one value must be defined.
@rdeltour rdeltour added type: improvement The issue suggests an improvement of an existing feature status: accepted Ready to be further processed spec: EPUB 3.x Impacting the support of EPUB 3.x specifications labels Jan 25, 2019
@rdeltour rdeltour added this to the 4.2.0-next milestone Jan 25, 2019
rdeltour added a commit that referenced this issue Feb 25, 2019
@rdeltour
feat: improve wording of message OPF-025
cecaa76 
Fix #959
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: accepted Ready to be further processed labels Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec: EPUB 3.x Impacting the support of EPUB 3.x specifications status: completed Work completed, can be closed type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Milestone
4.2.0-beta
Development

No branches or pull requests
1 participant
@rdeltour