[fix #769] allowing aria role attributes in svg #780

murata2makoto · 2017-07-09T23:26:24Z

Schema changes required for addressing #769. Not unit tests (sorry!).

…uagecode | string "".

…ria-30.rnc to renderable elements.

tofi86 · 2017-07-10T08:54:32Z

Thanks for pushing those changes! However, this seems to have quite a few side effects:

Failed tests:

  testValidateEPUBTestSvg(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBInvalidNcx(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[MessageId.RSC_012, MessageId.RSC_012]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_012, MessageId.RSC_012]>

  testValidateEPUBValidNcx(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBMp3(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBInvalidMp3(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[MessageId.OPF_043]> but was:<[MessageId.OPF_043, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBMp3WithFallback(com.adobe.epubcheck.api.Epub30CheckTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBPLoremSvg(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBPLoremSvgHyperlink(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUBPLoremSvgHyperlinkNoTitle(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUB30_issue134_1(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUB30_issue134_2(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[MessageId.OPF_014, MessageId.OPF_014]> but was:<[MessageId.RSC_005, MessageId.OPF_014, MessageId.RSC_005, MessageId.OPF_014]>

  testValidateEPUB30_issue134_3(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[MessageId.OPF_014]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.OPF_014]>

  testValidateEPUB30_svgCoverImage(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUB30_svgInSpine(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testValidateEPUB30_svgReferenced(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testFXL_WithSVG(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  testFXL_WithSVG_NoViewbox(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[MessageId.HTM_048]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005, MessageId.HTM_048]>

  testFXL_WithSVGNotInSpine(com.adobe.epubcheck.api.Epub30CheckExpandedTest): The error results do not match expected:<[]> but was:<[MessageId.RSC_005, MessageId.RSC_005, MessageId.RSC_005]>

  viewport_Test(com.adobe.epubcheck.test.opf_Test): Outputted json isn't as expected. (..)

  hyperlinksTest(com.adobe.epubcheck.test.xhtml_Test): Outputted json isn't as expected. (..)

  html5_deprecated_epub3Test(com.adobe.epubcheck.test.xhtml_Test): Outputted json isn't as expected. (..)

  testLoremSVG30(com.adobe.epubcheck.ocf.OCFCheckerTest): expected:<0> but was:<3>

  testLoremHyperlink30(com.adobe.epubcheck.ocf.OCFCheckerTest): expected:<0> but was:<3>

  testValidateSVGRectInvalid(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[RSC-005, RSC-005, RSC-005, RSC-005]> but was:<[RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005]>

  testValidateSVGRectValid(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005, RSC-005]>

  testValidateXHTMLOPSSVG001(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005]>

  testValidateXHTMLOPSSVG002(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005]>

  testValidateXHTML_SVG001(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[RSC-005, RSC-005]> but was:<[RSC-005, RSC-005, RSC-005, RSC-005]>

  testValidateXHTML_SVGLinks(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005]>

  testValidateXHTML_SVGLinks_MisssingTitle(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005]>

  testValidateSVG_Links(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005, RSC-005, RSC-005]>

  testValidateSVG_ValidStyleWithoutType_issue688(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005, RSC-005, RSC-005]>

  testValidateSVG_Links_MisssingTitle(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005, RSC-005]>

  testValidateSVGIssue219(com.adobe.epubcheck.ops.OPSCheckerTest): The error results do not match expected:<[]> but was:<[RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005, RSC-005]>

I will have to take a closer look at the failing tests and push changes or isolate specific tests.

mattgarrish · 2017-07-10T12:28:21Z

Moving the element declarations to epub-svg11-30.rnc has taken them out of the default SVG namespace. I believe you just need to redeclare in that file:

default namespace = "http://www.w3.org/2000/svg"

murata2makoto · 2017-07-10T12:39:28Z

Sorry. Matt is right. I introduce a namespace dcl in epub-svg11-30.rnc.

tofi86 · 2017-07-10T13:05:39Z

Great! Thanks for the quick fix!

I'm going to review the changes soon and will add a unit test for it based on @rdeltour's initial example in #769

refs w3c#769 w3c#780

tofi86 · 2017-07-16T22:02:35Z

Added a test with the example from #769 and unit tests are fine. Changes approved.

murata2makoto added 2 commits July 7, 2017 19:26

Allow xml:lnag="" by replacing datatype.languagecode by datatype.lang…

bcadc90

…uagecode | string "".

Introduced ARIA attributes (except describedat) in /mod/html5/html5-a…

2d04089

…ria-30.rnc to renderable elements.

tofi86 self-requested a review July 10, 2017 08:52

tofi86 assigned murata2makoto Jul 10, 2017

tofi86 added the bugfix label Jul 10, 2017

tofi86 added this to the 4.1.0 milestone Jul 10, 2017

Fixed a namespace bug, thanks to Matt.

99e36a9

tofi86 mentioned this pull request Jul 16, 2017

ARIA role attribute should be allowed on SVG elements #769

Closed

Add a test for SVG schema changes for aria attributes

15505ff

refs w3c#769 w3c#780

tofi86 approved these changes Jul 16, 2017

View reviewed changes

tofi86 merged commit 49412e0 into w3c:master Jul 16, 2017

tofi86 changed the title ~~Fix 769 allowing aria role attributes in svg~~ [fix #769] allowing aria role attributes in svg Jul 16, 2017

murata2makoto deleted the fix-769-allowing-ARIA-role-attributes-in-SVG branch July 27, 2017 05:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix #769] allowing aria role attributes in svg #780

[fix #769] allowing aria role attributes in svg #780

murata2makoto commented Jul 9, 2017

tofi86 commented Jul 10, 2017

mattgarrish commented Jul 10, 2017

murata2makoto commented Jul 10, 2017

tofi86 commented Jul 10, 2017

tofi86 commented Jul 16, 2017

[fix #769] allowing aria role attributes in svg #780

[fix #769] allowing aria role attributes in svg #780

Conversation

murata2makoto commented Jul 9, 2017

tofi86 commented Jul 10, 2017

mattgarrish commented Jul 10, 2017

murata2makoto commented Jul 10, 2017

tofi86 commented Jul 10, 2017

tofi86 commented Jul 16, 2017