fix: resolve relative URIs against their base #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeltour
added
the
status: needs review
- re-implement the `PathUtil` class to fix various URI resolution issues - remove the 3-arg `resolveRelativeReference` method - systematically resolve URI references in Content Documents against the base URI - the base URI is initially set to the document path, and overriden with `xml:base` attributes or HTML’s `base` element - add more exhaustive tests for URI normalization/resolution logic What this PR doesn’t do: - cleanup the many uses of paths strings, where we should really use URIs. The `PathUtil` code is mostly a hack, when we should rely on more robust URI normalization/resolution logic from URIs. - implement proper base resolution logic (`xml:base` should be deprecated, and only the first `base` element should be taken into account). See also w3c/epub-specs#1217. Fixes #527
rdeltour
force-pushed
the
fix/issue-527/base-uri
branch
from
cf1baa6
to
a84e08c
Compare
rdeltour
added
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathUtilclass to fix various URI resolution issuesresolveRelativeReferencemethodbase URI
xml:baseattributes or HTML’sbaseelementWhat this PR doesn’t do:
The
PathUtilcode is mostly a hack, when we should rely on more robustURI normalization/resolution logic from URIs.
xml:baseshould be deprecated,and only the first
baseelement should be taken into account).See also xml:base attribute epub-specs#1217.
Fixes #527