Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "configuration" to the DOM. #115

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Jun 3, 2019

Fixes #111.


Preview | Diff

@mounirlamouri
Copy link
Member

@jernoble I think we should hold onto this until we decide how we want to handle the multi-configuration situation just to be safe. Though, I guess that the most likely scenario is that the attribute would become a union type that would be an attribute or a sequence.

@jernoble
Copy link
Contributor Author

jernoble commented Oct 16, 2019

Pinging this thread; during FOMS TPAC, this issue was raised, and since the spec does not seem to be moving in the direction of the "multi-configuration situation", it should not impact this pull request.

@chcunningham
Copy link
Contributor

I'm supportive. @mounirlamouri good to go?

</p>
<pre class='idl'>
dictionary MediaCapabilitiesEncodingInfo : MediaCapabilitiesInfo {
MediaEncodingConfiguration configuration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is defined for all descendents of MediaCapabilitiesInfo, could we move it to the parent dict?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're ready to once ^^ this minor question is settled :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I don't think we can move it to the parent, because of IDL. MediaEncodingConfiguration and MediaDecodingConfiguration are disjoint classes, and moving it to the parent would require that parameter be an "any".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good point!

@chcunningham chcunningham merged commit 37d6312 into w3c:master Oct 25, 2019
@chrisn chrisn mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to MediaConfigurations cannot be feature detected in older UAs.
3 participants