Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MediaStream in workers #26

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Expose MediaStream in workers #26

merged 2 commits into from
Apr 25, 2024

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jun 7, 2021 •
edited by pr-preview bot
Loading

@jan-ivar
Copy link
Member

@youennf Why? (I'm not opposed, just would like to know where this came up).

Naively, I'd expect streams to be useful only to access older (main-thread only) APIs?

@youennf
Copy link
Contributor Author

youennf commented Jun 10, 2021

Naively, I'd expect streams to be useful only to access older (main-thread only) APIs?

If we want to expose WebAudio or RTCPeerConnection APIs to workers, it is convenient to have MediaStream available there.
And it should not be a big deal to implement.

youennf
youennf commented Jun 10, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@alvestrand
Copy link
Contributor

At the moment, the only purpose would be to reuse libraries of JS code that already use MediaStreams.
We don't have any objects exposed that have MediaStream in their interface.
We should probably submit this when we have the proposal to import such an interface to Worker.

@alvestrand alvestrand added the Icebox Stuff that may be done one day, but not today. label Jun 10, 2021
@jan-ivar jan-ivar marked this pull request as draft October 13, 2022 14:58
@jan-ivar
Copy link
Member

w3c/mediacapture-fromelement#65 would be a reason to merge this.

jan-ivar
jan-ivar reviewed Feb 15, 2024
View reviewed changes
index.html Show resolved Hide resolved
@jan-ivar jan-ivar added Discuss at Next Meeting and removed Icebox Stuff that may be done one day, but not today. labels Feb 15, 2024
@dontcallmedom-bot
Copy link

This issue had an associated resolution in WebRTC February 2024 meeting – 20 February 2024 (Expose MediaStream in Workers):

RESOLUTION: Exposing MediaStream in workers is reasonable but low priority

@jan-ivar jan-ivar marked this pull request as ready for review March 14, 2024 14:57
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 18, 2024
@aosmond
Bug 1888634 - Disallow captureStream with canvas transferred to DOM w…
8c7ef92 
…orker. r=gfx-reviewers,lsalzman

This behaviour has yet to be defined by the spec and/or WPT, see:

w3c/mediacapture-fromelement#65
w3c/mediacapture-extensions#26
web-platform-tests/wpt#21102

Differential Revision: https://phabricator.services.mozilla.com/D207582
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Apr 18, 2024
@aosmond
Bug 1888634 - Disallow captureStream with canvas transferred to DOM w…
467baa2 
…orker. r=gfx-reviewers,lsalzman

This behaviour has yet to be defined by the spec and/or WPT, see:

w3c/mediacapture-fromelement#65
w3c/mediacapture-extensions#26
web-platform-tests/wpt#21102

Differential Revision: https://phabricator.services.mozilla.com/D207582
alvestrand
alvestrand approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is needed to unblock the OffscreenCanvas generating a stream in a worker, I'm fine with merging it now.

@jan-ivar jan-ivar merged commit 7ff754a into w3c:main Apr 25, 2024
@chrisguttandin chrisguttandin mentioned this pull request Apr 26, 2024
Open
aosmond added a commit to aosmond/gecko that referenced this pull request Aug 7, 2024
@aosmond
Bug 1888634 - Disallow captureStream with canvas transferred to DOM w…
73aa2d6 
…orker.

This behaviour has yet to be defined by the spec and/or WPT, see:

w3c/mediacapture-fromelement#65
w3c/mediacapture-extensions#26
web-platform-tests/wpt#21102

Differential Revision: https://phabricator.services.mozilla.com/D207582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-ivar jan-ivar jan-ivar left review comments

@alvestrand alvestrand alvestrand approved these changes

Assignees
No one assigned
Labels
ready for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youennf @jan-ivar @alvestrand @dontcallmedom-bot