Integrate "request permission to use" with user activation #401
Conversation
Allows "request permission to use" to accept an optional promise. The promise gets rejected if the page doesn't have transient activation. Also, when the promise is passed, the algorithm now consumes the user activation. If passed, the promise is resolved with the user's choice.
|
Expected use would be something like:
|
|
I kinda like this, because it works for legacy APIs (e.g. Geolocation) and for new APIs. |
|
The expected usage there is wrong. You cannot react to a promise while in parallel. You'd have to queue a task. Also, I think Notifications is currently a permission-thingie for which no user activation is required in one implementation (Chromium), but maybe that should be considered a bug. |
| <li>If |global| does not have [=transient activation=], [=queue a global task=] on | ||
| the [=user interaction task source=] given |global| to [=reject=] |promise| with a | ||
| "{{NotAllowedError}}" {{DOMException}} and abort these steps. | ||
| </li> | ||
| <li>Otherwise, [=consume user activation=] of |global|. |
There was a problem hiding this comment.
I'm not sure this really works if "requesting permission to use" is called while in parallel as the transient activation check really has to happen in the main thread.
| As a shorthand, <a>requesting permission to use</a> a {{DOMString}} |name|, is the same | ||
| as <a>requesting permission to use</a> a {{PermissionDescriptor}} with its | ||
| As a shorthand, <a>requesting permission to use</a> a {{DOMString}} |name| and |promise|, | ||
| is the same as <a>requesting permission to use</a> a {{PermissionDescriptor}} with its |
There was a problem hiding this comment.
Can you give an example of using this shorthand? Looking at https://notifications.spec.whatwg.org/#dom-notification-requestpermission... is it something like requesting permission to use "notifications" with |promise|? If so, s/and/with/?
(And probably {{PermissionDescriptor/name}} member set to |name| with |promise| below?)
| "export">request permission to use</dfn> a |descriptor:PermissionDescriptor|, with | ||
| optionally a |promise:Promise|: |
There was a problem hiding this comment.
We need to make call sites easy to read, and I don't think "request permission to use |descriptor| with |promise|" explains to readers what the promise is going to mean. Readers shouldn't need to click through in order to read the call site, which means the call site needs to mention [=transient activation=]. I think something like
| "export">request permission to use</dfn> a |descriptor:PermissionDescriptor|, with | |
| optionally a |promise:Promise|: | |
| "export">request permission to use</dfn> a |descriptor:PermissionDescriptor|, optionally | |
| with [=transient activation=] consumed through a |promise:Promise|: |
would be somewhat better, although "consumed through" is still obscure, and you might come up with better ideas.
There was a problem hiding this comment.
In that case you should define a named parameter: https://infra.spec.whatwg.org/#algorithm-params. (It's not clear to me how a caller would invoke the suggestion. Transient activation is also a property of a Window object.)
There was a problem hiding this comment.
hmm... I wonder then if we should define an entirely new algorithm that returns a promise (is not passed one), then see how many specs we can migrate over.
That would allow geolocation (and maybe other specs) to keep working, but provide the right infra for this.
Allows "request permission to use" to accept an optional promise.
The promise gets rejected if the page doesn't have transient activation. Also, when the promise is passed, the algorithm now consumes the user activation. If passed, the promise is resolved with the user's choice.
closes #194
Preview | Diff