Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bullet items on scripts and wasm #30

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Oct 9, 2024

Referring back to the discussion in w3c/epub-specs#2655.


Preview | Diff

@iherman
Copy link
Member Author

iherman commented Oct 9, 2024

@bduga would be great to get your reaction as well!

index.html Outdated Show resolved Hide resolved
@bduga
Copy link
Collaborator

bduga commented Oct 9, 2024

This seems fine to me, with Matt's clarification. I guess the only thing I disagree with is needing to add it to a new charter. It seems clear to me that wasm is already allowed, so we would only be clarifying that, which doesn't seem like a level 4 change. But also no harm adding it.

Copy link
Contributor

@wareid wareid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with Matt's clarification

Co-authored-by: Matt Garrish <[email protected]>
@iherman
Copy link
Member Author

iherman commented Oct 10, 2024

This seems fine to me, with Matt's clarification. I guess the only thing I disagree with is needing to add it to a new charter. It seems clear to me that wasm is already allowed, so we would only be clarifying that, which doesn't seem like a level 4 change.

As I said in w3c/epub-specs#2655 (comment) this may be interpreted as class 4 and may lead to discussions...

But also no harm adding it.

Better safe than sorry :-)

@iherman
Copy link
Member Author

iherman commented Oct 14, 2024

Merging outstanding PRs before it becomes unmanageable....

@iherman iherman merged commit dc2e590 into main Oct 14, 2024
iherman added a commit that referenced this pull request Oct 14, 2024
* main:
  settling on epub 3.4 (#32)
  Update the bullet items on scripts and wasm (#30)
  Go for the classical route for Rec (#28)
  Removed issue on annotation (#27)

# Conflicts:
#	index.html
iherman added a commit that referenced this pull request Oct 14, 2024
* main:
  Updated the thorium reference (#33)
  settling on epub 3.4 (#32)
  Update the bullet items on scripts and wasm (#30)
  Go for the classical route for Rec (#28)
  Removed issue on annotation (#27)
  Clarify the lead-in to the deliverables section (#25)

# Conflicts:
#	index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants