-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider updating Dedup definition to apply de-duplication to error values #126
Comments
As I just wrote in #125 (comment), the question of error values is irrelevant for |
You're right, |
As discussed in #125,
Dedup
/Distinct
currently does not handle the de-deduplication of error values which is important for handlingcustom set functions. I'd like to see Dedup updated toCOUNT(DISTINCT *)
. This case could be special-cased in the text, buthandle error values natively as it allows custom aggregatesto work over error values while having (what I think of as the expected)DISTINCT
handling handled before the aggregation.The text was updated successfully, but these errors were encountered: