Allow @ in tracestate key names for multi-tenant vendors #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2018 16:27
discostu105
reviewed
Aug 7, 2018
| ## Vendor name in a key | ||
|
|
||
| Sign `@` is allowed in a key for easy parsing of vendor name out of tracestate key. Idea is that with the registry of trace vendors one can easily understand the vendor name and how to parse it's trace state. Without `@` sign parsing will be more complicated. Also `@` sign has known semantics in | ||
| addressing for protocols like ftp and e-mails. |
discostu105
reviewed
Aug 7, 2018
| ## Vendor name in a key | ||
|
|
||
| Sign `@` is allowed in a key for easy parsing of vendor name out of tracestate key. Idea is that with the registry of trace vendors one can easily understand the vendor name and how to parse it's trace state. Without `@` sign parsing will be more complicated. Also `@` sign has known semantics in | ||
| addressing for protocols like ftp and e-mails. |
There was a problem hiding this comment.
Also, not sure if "Also @ sign has known semantics in addressing for protocols like ftp and e-mails" really adds a lot here. Would it hurt to remove this?
There was a problem hiding this comment.
I think it's fine. Any way to explain it easier?
There was a problem hiding this comment.
I't ok, I'm also fine with keeping this.
SergeyKanzhelev
changed the title
AloisReitbauer
approved these changes
Aug 8, 2018
| lcalpha = %x61-7A ; a-z | ||
| ``` | ||
|
|
||
| Note that identifiers MUST begin with a lowercase letter, and can only contain lowercase letters `a`-`z`, digits `0`-`9`, underscores `_`, dashes `-`, asterisks `*`, and forward slashes `/`. | ||
| Note that identifiers MUST begin with a lowercase letter, and can only contain lowercase letters `a`-`z`, digits `0`-`9`, underscores `_`, dashes `-`, asterisks `*`, and forward slashes `/`. For multi-tenant vendors scenarios `@` sign can be used to prefix vendor name. Suggested use is to allow set tenant id in the beginning of key like `fw529a3039@dt` - `fw529a3039` is a tenant id and `@dt` is a vendor name. Searching for `@dt=` would be more robust for parsing (searching for all vendor's keys). |
There was a problem hiding this comment.
I think you all are way too quick to make decisions like this.
|
for posterity there was mention about no objections. in the doc it also
said that many people were only partially available monday. can folks that
agree we should document this practice please make yourselves known, or at
least say who was present when no objections were claimed?
it is good to make decisions but it should be transparent which
"implementors" will be using this and how. I am not saying this is a bad
call just didn't see folks outside DT talking about their use cases for
this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#137